Cannot fake primitive bindings using config

[ol1s]

Description:

• Laravel Version: 8.50.0
• PHP Version: 7.4.23
• Database Driver & Version:

When I bind a primitive to a class using a config value I cannot override this in my feature tests

Steps To Reproduce:

Setup primitive bindings in container:

class AppServiceProvider extends ServiceProvider
{
    public function register()
    {
        $this->app->when(ExampleService::class)
            ->needs('$baseUrl')
            ->give(config('services.example.host'));
    }
}

Inject bindings into constructor:

class ExampleService
{
    public function __construct(string $baseUrl)
    {
    }
}

Override (fake) the config value in feature test:

class ExampleFeatureTest extends TestCase
{
    protected function setUp(): void
    {
        parent::setUp();
        config()->set('services.example.host', 'http://test');
    }
}

Result

The value of the config('services.example.host') passed to the primitive binding $baseUrl in ExampleService remains as it was at boot-time (ie. null)

BindingResolutionException(code: 0): Unresolvable dependency resolving [Parameter #0 [ <required> string $baseUrl ]]
in class App\\Services\\ExampleService at vendor/laravel/framework/src/Illuminate/Container/Container.php:1104)

Expected

The value of config('services.example.host') injected from the container should instead be http://test

Workaround

I had to abandon contextual binding and instead decorate my class using setter as follows:

class AppServiceProvider extends ServiceProvider
{
    public function register()
    {
        $this->app->extend(ExampleService::class, function ($class) {
            return $class->setBaseUrl(config('services.example.host'));
        });
    }
}

class ExampleService
{
    public function setBaseUrl(string $baseUrl): self
    {
        //etc
        return $this;
    }
}

[X-Coder264]

$this->app->when(ExampleService::class)
            ->needs('$baseUrl')
            ->give(config('services.example.host'));

must be

use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\Container\Container;

$this->app->when(ExampleService::class)
            ->needs('$baseUrl')
            ->give(static function (Container $container): string {
                return $container->make(Repository::class)->get('services.example.host');
            });

and then it works.

This way the value is lazily fetched from the config when the service is instantiated, instead of being set at app boot time.

[ol1s]

@X-Coder264 Thanks so much for your reply.

I've also noticed there is a giveConfig(...) method available on the contextual binder, do you know if this behaves lazily or binds at boot?

[X-Coder264]

Np.

It behaves lazily.

[ol1s]

I know this is an old topic so forgive me......however I have started using the giveConfig(...) method in my service providers but annoyingly vcscode + intelephense is giving me a:

Undefined method 'giveConfig'

This is becuase the chained when->needs methods return a Illuminate\Contracts\Container\ContextualBindingBuilder type which DOESN'T contain the giveConfig() method.

Makes me wonder whether this new method should also be part of the contract?

https://github.com/laravel/framework/blob/8.x/src/Illuminate/Contracts/Container/ContextualBindingBuilder.php

[X-Coder264]

@ol1s #38925 ;)