[8.x] Fix test suite failing in CI, add suggestion for PHP extension "bcmath" #36457
Conversation
derekmd
force-pushed
the
add-math-extension
branch
4 times, most recently
from
e94fb5b to
753b0a9
Compare
derekmd
changed the title
In v8.12.0 the validation rule 'multiple_of' started calling global function bcmod() which is part of the "bcmath" extension. The GitHub Actions environment setup for PHP 7.3 looks to no longer enable this extension by default. Explicitly configure it and add @requires phpdoc to the 'multiple_of' test method.
derekmd
force-pushed
the
add-math-extension
branch
from
753b0a9 to
0761d6b
Compare
|
The actual issue is that we're using ubuntu-latest and GH Actions just rolled out ubuntu-20.04 which contains a PHP 7.3 build without some of the extensions included in ubuntu-18.04 & ubuntu-16.04. I'll be patching all of our repos in a bit to make explicit use of ubuntu-18.04 to make sure this doesn't happens again in the future. Someone has already sent in a PR to GH Actions to patch the ubuntu-20.04 env. When that's merged I'll be upgrading all of our builds to ubuntu-20.04 |
|
Thanks for looking into this though! |
|
@driesvints: You have ended my 100% merge rate in the Laravel ecosystem and I must now commit seppuku. Are the |
|
@derekmd haha, sorry man. No since that would suppress the failing test and we wouldn't have caught this. |
In v8.12.0 the validation rule
multiple_ofstarted calling global functionbcmod()(#34971) which isn't part of the standard library. PHP extension "bcmath" must be installed which is typically included with distributions.However the GitHub Actions environment setup for PHP 7.3 looks to no longer enable this extension by default so explicitly add it to the config.