[8.x] Make multiple_of validation rule handle non-integer values - #34971
Merged
Conversation
driesvints
changed the title
multiple_of validation rule handle non-integer valuesmultiple_of validation rule handle non-integer values
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
multiple_ofdoes not validate some of the cases where the input is an integer multiple of the step becausefmoddoes not produce a zero on some of the cases, e.g.fmod(2, .1) = .1andfmod(.9, .3) = some really small but non zero value.This addes the tests for those cases and solves the issue by using
bcmodand checking the first 16 digits after the decimal point.Linked: discussion in #34960 and initial PR #34959 which I set to branch that I didn't intend to.