[9.x] Add test cases for multiple_of
validation rule
#34959
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test cases were not conforming to
step
constraint in HTML and (in my opinion) not correct per se, i.e. 10.5 is a multiple of .3 as much as it is a multiple of .5.I also added a few more test cases where the behaviour of
multiple_of
is not what one would expect and not how HTML validation handles them (emphasis mine):Currently the validation rule fails some cases of recognizing that the value is "an integral multiple of the allowed value step" (because PHP's
fmod
fails that) and doesn't even attempt to tie the check together withmin
.https://html.spec.whatwg.org/multipage/input.html#the-step-attribute