Skip to content

[5.8] Fix formatting of DocBlock in factory.stub #29199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019
Merged

[5.8] Fix formatting of DocBlock in factory.stub #29199

merged 1 commit into from
Jul 17, 2019

Conversation

adevade
Copy link
Contributor

@adevade adevade commented Jul 17, 2019

This change allows all IDEs to properly parse the imported variable.

Before it was invalid because a DocBlock should always start with /** (two asterisks), and the syntax for @var was in the wrong order.

It's a non-breaking change because we're just updating a comment, and it will only benefit users who generate factories after the PR is merged.

@RikSomers
Copy link

RikSomers commented Jul 17, 2019

This has been attempted a couple times before, see #22553 #24647 #27103

I'm not against it personally, but just to let you know.

@driesvints driesvints merged commit 4aa93f8 into laravel:5.8 Jul 17, 2019
@driesvints
Copy link
Member

Thanks

@adevade
Copy link
Contributor Author

adevade commented Jul 17, 2019

@RikSomers Hey, look at that! I just noticed it was not correctly highlighted in my editor and thought that if it's already there it might as well be formatted right.

@GrahamCampbell GrahamCampbell changed the title Fix formatting of DocBlock in factory.stub [5.8] Fix formatting of DocBlock in factory.stub Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants