Skip to content

[5.7] Add model factory type annotation#27103

Closed
jmsfwk wants to merge 1 commit into
laravel:5.7from
jmsfwk:patch-1
Closed

[5.7] Add model factory type annotation#27103
jmsfwk wants to merge 1 commit into
laravel:5.7from
jmsfwk:patch-1

Conversation

@jmsfwk

@jmsfwk jmsfwk commented Jan 8, 2019

Copy link
Copy Markdown

Adding the type annotation to the model factory stub will help autocompletion tools to provide method suggestions.

This is more useful for methods like state() or afterCreating() that might not be used as often as define().

@driesvints driesvints changed the title Add model factory type annotation [5.7] Add model factory type annotation Jan 8, 2019
@ahinkle

ahinkle commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

See #24647

@driesvints

Copy link
Copy Markdown
Member

Please see linked PR above

@driesvints driesvints closed this Jan 8, 2019
@deleugpn

deleugpn commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

This was added and removed and added and removed countless of times. Last time it was added, Graham simply removed it because it was /* instead of /** and he thinks it's an invalid docblocks and phpstorm is wrong for understanding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants