Skip to content

[5.7] Add model factory type annotation #27103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[5.7] Add model factory type annotation #27103

wants to merge 1 commit into from

Conversation

jmsfwk
Copy link

@jmsfwk jmsfwk commented Jan 8, 2019

Adding the type annotation to the model factory stub will help autocompletion tools to provide method suggestions.

This is more useful for methods like state() or afterCreating() that might not be used as often as define().

@driesvints driesvints changed the title Add model factory type annotation [5.7] Add model factory type annotation Jan 8, 2019
@ahinkle
Copy link
Contributor

ahinkle commented Jan 8, 2019

See #24647

@driesvints
Copy link
Member

Please see linked PR above

@driesvints driesvints closed this Jan 8, 2019
@deleugpn
Copy link
Contributor

deleugpn commented Jan 9, 2019

This was added and removed and added and removed countless of times. Last time it was added, Graham simply removed it because it was /* instead of /** and he thinks it's an invalid docblocks and phpstorm is wrong for understanding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants