Skip to content

[5.8] Fix container docblock #26856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2018
Merged

[5.8] Fix container docblock #26856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Illuminate/Container/Container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,8 @@ public function makeWith($abstract, array $parameters = [])
* @param string $abstract
* @param array $parameters
* @return mixed
*
* @throws \Illuminate\Contracts\Container\BindingResolutionException
Copy link
Contributor

@X-Coder264 X-Coder264 Dec 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuanQuynh This should be added to the Container interface docblock too, right? :)

Copy link
Contributor Author

@seriquynh seriquynh Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@X-Coder264 I agree with you but it's a breaking change. I am not sure Mr.Otwell want to add it to the Container interface. Someone may do that.

Copy link
Contributor

@X-Coder264 X-Coder264 Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuanQuynh From a purely theoretical standpoint, yes. But realistically looking the exception in question is in the contracts namespace which means that at least some method from the contract is supposed to throw it (otherwise it wouldn't exist there in the first place). Besides you did send this PR to the master (5.8) branch which is precisely the branch where you send breaking changes so I don't see a problem :)

Copy link
Contributor Author

@seriquynh seriquynh Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@X-Coder264 Ok. I will create a new pull request soon and reference it with this. :)

*/
public function make($abstract, array $parameters = [])
{
Expand Down Expand Up @@ -630,6 +632,8 @@ public function get($id)
* @param string $abstract
* @param array $parameters
* @return mixed
*
* @throws \Illuminate\Contracts\Container\BindingResolutionException
*/
protected function resolve($abstract, $parameters = [])
{
Expand Down Expand Up @@ -816,6 +820,8 @@ public function build($concrete)
*
* @param array $dependencies
* @return array
*
* @throws \Illuminate\Contracts\Container\BindingResolutionException
*/
protected function resolveDependencies(array $dependencies)
{
Expand Down