[5.8] Fix container docblock #26856
[5.8] Fix container docblock #26856
Conversation
seriquynh
commented
Dec 14, 2018
seriquynh
commented
- Container::resolvePrimitive() or Container::resolveClass() may throws BindingResolutionException.
- Container::resolveDependencies() calls Container::resolvePrimitive() or Container::resolveClass() without try-catch block.
- Container::build() calls Container::resolveDependencies() without try-catch block.
- Container::resolve() calls Container::build() without try-catch block.
- Container::make() directly calls Container::resolve().
| * @param array $parameters | ||
| * @return mixed | ||
| * | ||
| * @throws \Illuminate\Contracts\Container\BindingResolutionException |
There was a problem hiding this comment.
@XuanQuynh This should be added to the Container interface docblock too, right? :)
There was a problem hiding this comment.
@X-Coder264 I agree with you but it's a breaking change. I am not sure Mr.Otwell want to add it to the Container interface. Someone may do that.
There was a problem hiding this comment.
@XuanQuynh From a purely theoretical standpoint, yes. But realistically looking the exception in question is in the contracts namespace which means that at least some method from the contract is supposed to throw it (otherwise it wouldn't exist there in the first place). Besides you did send this PR to the master (5.8) branch which is precisely the branch where you send breaking changes so I don't see a problem :)
There was a problem hiding this comment.
@X-Coder264 Ok. I will create a new pull request soon and reference it with this. :)
3 participants
