[5.4] Test predis and phpredis together #17882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taylorotwell: Should we make sure PhpRedis supports |
|
Yes, the whole point is for them to be basically 100% compatibility so you can switch without noticing. If we can't hit that goal then PhpRedis would just need to be removed. |
|
This breaks my tests locally unless I have PHPRedis installed. How can we skip those tests if it is not installed? It's impossible for me to test Laravel locally now. :( |
|
Adding some logic to tell dataprovider function don't put ['phpredis'] in
the returned array will be good.
Having said that, it is not that hard to install phpredis? In ubuntu sudo
apt-get install php-redis does that.
|
|
@halaei I think you meant to tag @taylorotwell instead of me 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen for #17853