[5.4] Test and fix RedisQueue for phpredis #17853

halaei · 2017-02-09T20:58:32Z

Tests for both phpredis and predis: see .travis.yml file and InteractsWithRedis trait.
Fix RedisQueue for phpredis: call to zadd.
Fix tests: phpredis may be case sensitive so 'WITHSCORES' should be converted to 'withscores'

halaei · 2017-02-10T10:12:31Z

Many phpnotice are printed to the travis-ci log. I think it has something to do with phpredis connection being open and the pcntl_fork in FileSystemTest.

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

PHP Notice:  Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

Notice: Unknown: send of 6 bytes failed with errno=32 Broken pipe in Unknown on line 0

tillkruss · 2017-02-10T16:43:20Z

Is that ZADD fix still nessesary. Didn't #17832 fix that already?

halaei · 2017-02-10T19:11:58Z

I don't know, I was writing this PR before #17832, maybe necessary maybe not, but does not hurt?

tillkruss · 2017-02-10T19:30:07Z

I wouldn't change it, unless it's nessesary.

halaei · 2017-02-10T20:09:49Z

Let me check then

halaei · 2017-02-10T20:13:03Z

No it does not work without the change. So the change is required.

halaei · 2017-02-10T20:14:44Z

Sorry, the change is not required :D. Only mock tests failed

tillkruss · 2017-02-10T20:16:33Z

Awesome! Great work otherwise.

tillkruss · 2017-02-10T20:16:58Z

src/Illuminate/Queue/RedisQueue.php

@@ -123,7 +123,7 @@ public function later($delay, $job, $data = '', $queue = null)
    protected function laterRaw($delay, $payload, $queue = null)
    {
        $this->getConnection()->zadd(
-            $this->getQueue($queue).':delayed', $this->availableAt($delay), $payload
+            $this->getQueue($queue).':delayed', [$payload => $this->availableAt($delay)]


Not necessary.

tillkruss · 2017-02-10T20:17:20Z

tests/Queue/QueueRedisQueueTest.php

-            json_encode(['displayName' => 'foo', 'job' => 'foo', 'maxTries' => null, 'timeout' => null, 'data' => ['data'], 'id' => 'foo', 'attempts' => 0])
+            [
+                json_encode(['displayName' => 'foo', 'job' => 'foo', 'maxTries' => null, 'timeout' => null, 'data' => ['data'], 'id' => 'foo', 'attempts' => 0]) => 2,
+            ]


Not necessary.

tillkruss · 2017-02-10T20:17:26Z

tests/Queue/QueueRedisQueueTest.php

-            json_encode(['displayName' => 'foo', 'job' => 'foo', 'maxTries' => null, 'timeout' => null, 'data' => ['data'], 'id' => 'foo', 'attempts' => 0])
+            [
+                json_encode(['displayName' => 'foo', 'job' => 'foo', 'maxTries' => null, 'timeout' => null, 'data' => ['data'], 'id' => 'foo', 'attempts' => 0]) => 2,
+            ]


Not necessary.

halaei · 2017-02-10T20:25:59Z

#17882

halaei added 2 commits February 10, 2017 00:07

test and fix for phpredis

6ba442b

case

644e39a

close redis connections in tests

a763af9

tillkruss suggested changes Feb 10, 2017

View reviewed changes

halaei mentioned this pull request Feb 10, 2017

[5.4] Test predis and phpredis together #17882

Merged

halaei closed this Feb 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[5.4] Test and fix RedisQueue for phpredis #17853

[5.4] Test and fix RedisQueue for phpredis #17853

Uh oh!

halaei commented Feb 9, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

tillkruss commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

tillkruss commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

tillkruss commented Feb 10, 2017 •

edited

Loading

Uh oh!

tillkruss Feb 10, 2017

Uh oh!

tillkruss Feb 10, 2017

Uh oh!

tillkruss Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

Uh oh!

[5.4] Test and fix RedisQueue for phpredis #17853

[5.4] Test and fix RedisQueue for phpredis #17853

Uh oh!

Conversation

halaei commented Feb 9, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

tillkruss commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

tillkruss commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

tillkruss commented Feb 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tillkruss Feb 10, 2017

Choose a reason for hiding this comment

Uh oh!

tillkruss Feb 10, 2017

Choose a reason for hiding this comment

Uh oh!

tillkruss Feb 10, 2017

Choose a reason for hiding this comment

Uh oh!

halaei commented Feb 10, 2017

Uh oh!

Uh oh!

tillkruss commented Feb 10, 2017 •

edited

Loading