Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for socketId #102

Merged
merged 1 commit into from
Feb 18, 2017
Merged

Add sanity check for socketId #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add sanity check for socketId, we don't want to add the X-Socket-Id h… 
…eader if the socketId is undefined.
  • Loading branch information
Jonathan Bastnagel committed Feb 17, 2017
commit 141a6d99f12df555412ec97a7c2ee44d7869ff90
4 changes: 3 additions & 1 deletion src/echo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ class Echo {
if (typeof jQuery.ajax != 'undefined' ) {
jQuery.ajaxSetup({
beforeSend: (xhr) => {
xhr.setRequestHeader('X-Socket-Id', this.socketId());
if (this.socketId()) {
xhr.setRequestHeader('X-Socket-Id', this.socketId());
}
}
});
}
Expand Down