Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for socketId #102

Merged
merged 1 commit into from
Feb 18, 2017
Merged

Add sanity check for socketId #102

merged 1 commit into from
Feb 18, 2017

Conversation

0xn3bs
Copy link

@0xn3bs 0xn3bs commented Feb 17, 2017

This fixes the jQuery interceptor. We don't want to add the X-Socket-Id header if the socketId is undefined.

This bug managed to break the Google Maps API through jQuery.

@taylorotwell taylorotwell merged commit e9118d9 into laravel:master Feb 18, 2017
@bbashy
Copy link

bbashy commented May 25, 2017

I'm getting this error and just wondering if it's related?

XMLHttpRequest cannot load https://maps.googleapis.com/maps/api/geocode/json?address=someaddress&key=keyhere.
Request header field X-Socket-Id is not allowed by Access-Control-Allow-Headers in preflight response.

@morloderex
Copy link

@bbashy It might be because jquery.ajaxSetup is global setup of the .ajax method....

@bbashy
Copy link

bbashy commented May 25, 2017

@morloderex And so now every ajax call is now including X-Socket-Id header?

I tried commenting out the part where it adds it to the headers and it was still happening.

@morloderex
Copy link

@bbashy It seems like it. yes.

@bbashy
Copy link

bbashy commented May 26, 2017

Getting this as well just because Echo is loaded.

Request header field Access-Control-Allow-Origin is not allowed by Access-Control-Allow-Headers in preflight response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants