fix: in iteration node picker may show the wrong var type #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
crazywoola
approved these changes
Jun 20, 2024
dosubot
bot
added
🐞 bug
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 21, 2024
* refs/heads/main: feat: option to hide workflow steps (#5436) feat(api/auth): switch-to-stateful-authentication (#5438) feat: add support for bedrock claude-3-5-sonnet-20240620 (#5461) feat: add support for claude-3-5-sonnet-20240620 (#5452) fix/i18n: correct `indexMethodHighQualityTip` (#5431) fix: some types of buttons ui breaks (#5437) fix: in iteration node picker may show the wrong var type (#5435) refactor: extract vdb configs into pydantic-setting based dify configs (#5426) refactor: Remove unused code in large_language_model.py (#5433) improve: unify Excel files parsing in either xls or xlsx file format by Pandas (#4965) fix: add notion page in knowledge (#5430) fix: annotation id not pass to update setting (#5429) fix(core): Fix incorrect type hints. (#5427) fix: workflow note node copy & link style (#5428) fix: button component will refresh page (#5420)
XiaoLey
pushed a commit
to XiaoLey/dify
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In iteration node, if var type is not string and $item or $index, it always return string.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes