Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button component will refresh page #5420

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Jun 20, 2024

Description

Fix: button component will refresh page.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@iamjoel iamjoel requested a review from takatost June 20, 2024 04:40
@iamjoel iamjoel marked this pull request as ready for review June 20, 2024 04:41
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 20, 2024
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Jun 20, 2024
@iamjoel iamjoel merged commit 51d34f5 into main Jun 20, 2024
6 checks passed
@iamjoel iamjoel deleted the fix/generation-run-refresh branch June 20, 2024 04:44
ZhouhaoJiang added a commit that referenced this pull request Jun 21, 2024
* refs/heads/main:
  feat: option to hide workflow steps (#5436)
  feat(api/auth): switch-to-stateful-authentication (#5438)
  feat: add support for bedrock claude-3-5-sonnet-20240620 (#5461)
  feat: add support for claude-3-5-sonnet-20240620 (#5452)
  fix/i18n: correct `indexMethodHighQualityTip` (#5431)
  fix: some types of buttons ui breaks (#5437)
  fix: in iteration node picker may show the wrong var type (#5435)
  refactor: extract vdb configs into pydantic-setting based dify configs (#5426)
  refactor: Remove unused code in large_language_model.py (#5433)
  improve: unify Excel files parsing in either xls or xlsx file format by Pandas (#4965)
  fix: add notion page in knowledge (#5430)
  fix: annotation id not pass to update setting (#5429)
  fix(core): Fix incorrect type hints. (#5427)
  fix: workflow note node copy & link style (#5428)
  fix: button component will refresh page (#5420)
XiaoLey pushed a commit to XiaoLey/dify that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants