Skip to content

fix: change write to db order #35948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumGhost merged 2 commits into from
May 9, 2026
Merged

fix: change write to db order #35948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a4720
fix: change write to db order
fatelei May 9, 2026
c75d1f9
chore: remove comment
fatelei May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions api/services/file_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,14 @@ def upload_file(
hash=hashlib.sha3_256(content).hexdigest(),
source_url=source_url,
)
# The `UploadFile` ID is generated within its constructor, so flushing to retrieve the ID is unnecessary.
# We can directly generate the `source_url` here before committing.
if not upload_file.source_url:
upload_file.source_url = file_helpers.get_signed_file_url(upload_file_id=upload_file.id)

with self._session_maker(expire_on_commit=False) as session:
session.add(upload_file)
session.commit()

if not upload_file.source_url:
upload_file.source_url = file_helpers.get_signed_file_url(upload_file_id=upload_file.id)

return upload_file

@staticmethod
Expand Down
Loading