Skip to content

fix: change write to db order#35948

Merged
QuantumGhost merged 2 commits into
langgenius:mainfrom
fatelei:issue-35943
May 9, 2026
Merged

fix: change write to db order#35948
QuantumGhost merged 2 commits into
langgenius:mainfrom
fatelei:issue-35943

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented May 9, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #35943

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@fatelei fatelei requested a review from QuantumGhost as a code owner May 9, 2026 01:59
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 41.39% +41.39%
Strict coverage 0.00% 40.91% +40.91%
Typed symbols 0 20,736 +20,736
Untyped symbols 0 29,708 +29,708
Modules 0 2538 +2,538

Comment thread api/services/file_service.py Outdated
QuantumGhost
QuantumGhost previously approved these changes May 9, 2026
Copy link
Copy Markdown
Contributor

@QuantumGhost QuantumGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 9, 2026
@QuantumGhost QuantumGhost enabled auto-merge May 9, 2026 02:29
@QuantumGhost QuantumGhost added this pull request to the merge queue May 9, 2026
Merged via the queue into langgenius:main with commit c74cbb6 May 9, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.14.0 regression] file_service.upload_file fails with "Upload file <uuid> not found" when scoped FileAccessController is active

2 participants