Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MCP SSE Model tool mode issue #7360

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix: MCP SSE Model tool mode issue #7360

merged 2 commits into from
Mar 31, 2025

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes a few changes to the MCPToolsComponent class in the src/backend/base/langflow/components/tools/mcp_component.py file. The most significant change is the removal of the sse_url attribute.

Codebase simplification:

@edwinjosechittilappilly edwinjosechittilappilly requested review from Copilot and phact and removed request for Copilot March 31, 2025 16:14
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 31, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the MCP SSE Model tool mode by removing the obsolete sse_url attribute from the MCPToolsComponent class.

  • Removed the sse_url attribute from the MCPToolsComponent class.
  • Code cleanup aimed at simplifying the component configuration.
Comments suppressed due to low confidence (1)

src/backend/base/langflow/components/tools/mcp_component.py:31

  • The 'sse_url' attribute removal is not reflected in the default_keys list. Please update default_keys to remove the obsolete 'sse_url' entry.
default_keys: list[str] = ["code", "_type", "mode", "command", "sse_url", "tool_placeholder", "tool_mode", "tool"]

@github-actions github-actions bot added the bug Something isn't working label Mar 31, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 31, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 31, 2025
@Cristhianzl Cristhianzl merged commit 2007495 into main Mar 31, 2025
41 of 42 checks passed
@Cristhianzl Cristhianzl deleted the mcp-hotfix branch March 31, 2025 16:59
QDDCoder pushed a commit to QDDCoder/langflow that referenced this pull request Apr 1, 2025
* commit '6c2ff92ccf083f038d9a97a749b4e0f30a60247a': (255 commits)
  docs: Update documentation and add TAVILY_API_KEY to environment variables (langflow-ai#7366)
  docs: mcp server component and integrations (langflow-ai#7286)
  docs: v1.3 (langflow-ai#7160)
  chore(deps-dev): bump vite from 5.4.14 to 5.4.16 in /src/frontend (langflow-ai#7365)
  fix: add secret key loading functionality to basic templates (langflow-ai#7363)
  docs: platform content (langflow-ai#7091)
  chore: bump langflow and langflow-base for 1.3.0 release (langflow-ai#7362)
  docs: ensure asset paths update on draft rebuilds (langflow-ai#7355)
  fix: Prevent API key banner from displaying when key is unavailable (langflow-ai#7356)
  fix: MCP SSE Model tool mode issue (langflow-ai#7360)
  feat: deprecate Parsing component and replace them in starter projects (langflow-ai#6697)
  fix: fixed the parser component (langflow-ai#7303)
  ref: split ast parsing / class exec loops (langflow-ai#7248)
  feat: Update AgentQL templates (langflow-ai#7165)
  feat: add a unified local vector store (langflow-ai#6995)
  fix: update currentflow to be fetched from Flow Store for icon to be rendered correctly (langflow-ai#7354)
  feat: expose serialization truncation constants in /config route (langflow-ai#7316)
  feat: lmprove MCP langflow port selection and error handling (langflow-ai#7327)
  fix: adds priority sorting for sidebar components and makes LanguageModel appear first (langflow-ai#7322)
  fix: make agent work with new tool mode backend updates (langflow-ai#7314)
  ...

# Conflicts:
#	src/frontend/src/utils/styleUtils.ts

更新到V1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants