Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds priority sorting for sidebar components and makes LanguageModel appear first #7322

Merged
merged 6 commits into from
Mar 31, 2025

Conversation

lucaseduoli
Copy link
Collaborator

This pull request introduces a new priority attribute to various models and updates the sorting logic to utilize this attribute. The most important changes include adding the priority attribute to the LanguageModelComponent class, updating the attribute handling functions, and modifying the frontend to sort items based on priority.

Changes to models:

Attribute handling updates:

Frontend updates:

@lucaseduoli lucaseduoli self-assigned this Mar 28, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Mar 28, 2025
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Mar 28, 2025
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Performance Report

Merging #7322 will improve performances by 56.67%

Comparing fix/component_orde (ab7cb94) with main (e82b23f)

Summary

⚡ 2 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 12.4 ms 7.9 ms +56.67%
test_cancel_nonexistent_build 12.2 ms 8.8 ms +38.5%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be in the backend as it would be a per component attribute (because we are adding the same attribute to all language models).

Also, this should have been added to the Component class.

I think if we are just changing things in the UI it must not depend on what the code tells us because if we change it later, users' components will still have the old value.

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 28, 2025
@@ -19,6 +19,7 @@ class LanguageModelComponent(LCModelComponent):
icon = "brain-circuit"
name = "LanguageModel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "LanguageModel"

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Mar 31, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 31, 2025
@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Mar 31, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 31, 2025
@lucaseduoli lucaseduoli added lgtm This PR has been approved by a maintainer and removed lgtm This PR has been approved by a maintainer labels Mar 31, 2025
@ogabrielluiz ogabrielluiz enabled auto-merge March 31, 2025 14:08
@ogabrielluiz ogabrielluiz added lgtm This PR has been approved by a maintainer and removed lgtm This PR has been approved by a maintainer labels Mar 31, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 7ba4bff Mar 31, 2025
50 of 53 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/component_orde branch March 31, 2025 14:54
Yukiyukiyeah pushed a commit that referenced this pull request Mar 31, 2025
…odel appear first (#7322)

* Added priority field to components

* Added priority as 0 to LanguageModelComponent

* Adds sorting based on priority

* refactor: remove redundant name attribute from LanguageModelComponent

* Updated custom component to include priority

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
QDDCoder pushed a commit to QDDCoder/langflow that referenced this pull request Apr 1, 2025
* commit '6c2ff92ccf083f038d9a97a749b4e0f30a60247a': (255 commits)
  docs: Update documentation and add TAVILY_API_KEY to environment variables (langflow-ai#7366)
  docs: mcp server component and integrations (langflow-ai#7286)
  docs: v1.3 (langflow-ai#7160)
  chore(deps-dev): bump vite from 5.4.14 to 5.4.16 in /src/frontend (langflow-ai#7365)
  fix: add secret key loading functionality to basic templates (langflow-ai#7363)
  docs: platform content (langflow-ai#7091)
  chore: bump langflow and langflow-base for 1.3.0 release (langflow-ai#7362)
  docs: ensure asset paths update on draft rebuilds (langflow-ai#7355)
  fix: Prevent API key banner from displaying when key is unavailable (langflow-ai#7356)
  fix: MCP SSE Model tool mode issue (langflow-ai#7360)
  feat: deprecate Parsing component and replace them in starter projects (langflow-ai#6697)
  fix: fixed the parser component (langflow-ai#7303)
  ref: split ast parsing / class exec loops (langflow-ai#7248)
  feat: Update AgentQL templates (langflow-ai#7165)
  feat: add a unified local vector store (langflow-ai#6995)
  fix: update currentflow to be fetched from Flow Store for icon to be rendered correctly (langflow-ai#7354)
  feat: expose serialization truncation constants in /config route (langflow-ai#7316)
  feat: lmprove MCP langflow port selection and error handling (langflow-ai#7327)
  fix: adds priority sorting for sidebar components and makes LanguageModel appear first (langflow-ai#7322)
  fix: make agent work with new tool mode backend updates (langflow-ai#7314)
  ...

# Conflicts:
#	src/frontend/src/utils/styleUtils.ts

更新到V1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants