fix: Fix crashes and enhance test reliability with session IDs #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Modify error handling in LCAgentComponent to only delete agent message if it has an ID attribute, preventing potential attribute errors
Modify the test_component_tool_with_api_key test to: - Use async_start() method for graph execution - Add session ID to graph - Improve result verification with vertex result tracking - Update import path for ChatOutput component
Update test_cycles.py to: - Add skip markers for tests that now require a LoopComponent - Improve error message with snapshots for debugging - Preserve existing test logic while marking as skipped
Add usefixtures decorator to ensure client is available for the tool calling agent test, improving test setup and reliability
Enhance test_component_toolkit.py by adding the client fixture to the test_component_tool_with_api_key method, ensuring proper test setup for API key-dependent scenarios
Add client fixture to the test_agent_component_with_calculator method to ensure proper test setup for API key-dependent scenarios
Remove commented-out test methods for checking required inputs across various components, as these tests were not providing significant value and the inputs are dynamic
ogabrielluiz
force-pushed
the
fixes-tests
branch
from
ef1527d to
55fdb85
Compare
dosubot
bot
added
size:L
dosubot
bot
added
size:M
github-actions
bot
added
bug
github-actions
bot
added
bug
github-actions
bot
added
bug
ogabrielluiz
force-pushed
the
fixes-tests
branch
from
c83b5a1 to
1880650
Compare
dosubot
bot
added
size:M
github-actions
bot
added
bug
dosubot
bot
added
size:L
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #6683 will improve performances by 42.27%Comparing Summary
Benchmarks breakdown
|
dosubot
bot
added
size:M
github-actions
bot
added
bug
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Yukiyukiyeah
pushed a commit
that referenced
this pull request
Mar 31, 2025
* test: Add session ID parameter to ToolCallingAgentComponent test * test: Add blocking for langchain_core runnables utility function * test: Add session ID generation to agent component test * fix: Safely delete agent message with ID check Modify error handling in LCAgentComponent to only delete agent message if it has an ID attribute, preventing potential attribute errors * test: Update ComponentToolkit test to use async start and verify results Modify the test_component_tool_with_api_key test to: - Use async_start() method for graph execution - Add session ID to graph - Improve result verification with vertex result tracking - Update import path for ChatOutput component * test: Skip cycle tests requiring LoopComponent Update test_cycles.py to: - Add skip markers for tests that now require a LoopComponent - Improve error message with snapshots for debugging - Preserve existing test logic while marking as skipped * test: Add client fixture to tool calling agent test Add usefixtures decorator to ensure client is available for the tool calling agent test, improving test setup and reliability * test: Add client fixture to component tool test with API key Enhance test_component_toolkit.py by adding the client fixture to the test_component_tool_with_api_key method, ensuring proper test setup for API key-dependent scenarios * test: Add client fixture to agent component test with calculator Add client fixture to the test_agent_component_with_calculator method to ensure proper test setup for API key-dependent scenarios * test: Disable redundant component input tests Remove commented-out test methods for checking required inputs across various components, as these tests were not providing significant value and the inputs are dynamic * test: Comment out condition to skip nodes with Tool outputs in setup.py * run formatter * test: Re-enable condition to skip nodes with Tool outputs in setup.py * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed a crash issue by updating message handling and improved test reliability by adding session ID parameters and fixtures across various tests. Additionally, modified error handling and removed redundant tests to streamline the testing process.
This is a selective rebase of #6672 so we can merge some of the fixes.