fix: Add optional flag to run all unit tests and fix tests #6672
+2,584
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the Makefile to support running all unit tests by introducing an 'all' flag. When set to true, the test filtering for 'not api_key_required' is removed, allowing all tests to be executed.
dosubot
bot
added
the
size:XS
Modify the Python test workflow to use the 'all=true' flag, enabling execution of all unit tests without filtering
Modify error handling in LCAgentComponent to only delete agent message if it has an ID attribute, preventing potential attribute errors
Modify the `map_outputs` method to automatically add a tool output if not already present, ensuring consistent output handling for components
Modify the test_component_tool_with_api_key test to: - Use async_start() method for graph execution - Add session ID to graph - Improve result verification with vertex result tracking - Update import path for ChatOutput component
Update test_cycles.py to: - Add skip markers for tests that now require a LoopComponent - Improve error message with snapshots for debugging - Preserve existing test logic while marking as skipped
dosubot
bot
added
size:M
ogabrielluiz
changed the title
dosubot
bot
added
size:XXL
Remove commented-out test methods for checking required inputs across various components, as these tests were not providing significant value and the inputs are dynamic
CodSpeed Performance ReportMerging #6672 will degrade performances by 41.22%Comparing Summary
Benchmarks breakdown
|
Modify test_component_to_tool.py to use .to_toolkit method when converting a calculator component to a toolkit for an agent
ogabrielluiz
changed the title
github-actions
bot
added
ignore-for-release
bug
github-actions
bot
added
bug
dosubot
bot
added
size:XL
github-actions
bot
added
bug
dosubot
bot
added
size:XXL
github-actions
bot
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an 'all' flag in the Makefile to allow execution of all unit tests, removing the filter for 'not api_key_required' when set to true.