Skip to content

fix(community): URL encode paths in GitHub document loader #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

fix(community): URL encode paths in GitHub document loader #8860

merged 2 commits into from
Sep 5, 2025

Conversation

@hntrl
Copy link
Member

@hntrl hntrl commented Sep 5, 2025

continuation of #8847

@eg-renovate-user @hntrl
fix: URL encode paths in GitHub document loader
f86add2 
Fix issue where directories with special characters (like '%5Fmeta')
would cause 404 errors because paths were not properly URL encoded
when constructing GitHub API requests.

- Apply encodeURIComponent() to path parameter in fetchRepoFiles method
- Add unit test to verify proper encoding of paths with special characters
@eg-renovate-user @hntrl
format: apply prettier formatting to GitHub loader files
9dac106
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

⚠️ No Changeset found

Latest commit: 9dac106

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchainjs-docs Ready Ready Preview Comment Sep 5, 2025 7:20pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchainjs-api-refs Ignored Ignored Sep 5, 2025 7:20pm

@hntrl hntrl mentioned this pull request Sep 5, 2025
Closed
@hntrl hntrl merged commit 545bab8 into main Sep 5, 2025
36 checks passed
@hntrl hntrl deleted the hunter/fix-github-loader-url-encoding branch September 5, 2025 19:24
@dd-eg-user
Copy link

dd-eg-user commented Sep 5, 2025

Thanks for getting this merged @hntrl !

since there is no changeset, how does this get released into the wild?

@hntrl
Copy link
Member Author

hntrl commented Sep 5, 2025

@dd-eg-user We're just using changesets for tracking right now. The latest community version was released alongside core in this PR

christian-bromann pushed a commit that referenced this pull request Sep 9, 2025
@hntrl @eg-renovate-user @christian-bromann
fix(community): URL encode paths in GitHub document loader (#8860)
9ccfb09 
Co-authored-by: Dylan Dignan <dylan.dignan@epicgames.com>
hntrl added a commit that referenced this pull request Oct 14, 2025
@hntrl
chore(community/v1): patch changes
9d066e5 
* #9144
* #9093
* #9069
* #8981
* #8978
* #8974
* #8949
* #8921
* #8922
* #8913
* #8911
* #8899
* #8896
* #7603
* #7808
* #8142
* #8246
* #8892
* #8842
* #8857
* #8862
* #8860
* #8861
* #8853
* #8859
* #8837
* #8501
* #8749
* #8720
* #8814
* #8808
* #8716
* #8714
* #8702
* #8558
* #8640
@hntrl hntrl mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hntrl @dd-eg-user @eg-renovate-user