Skip to content

Conversation

@dd-eg-user
Copy link

Fix issue where directories with special characters (like '%5Fmeta') would cause 404 errors because paths were not properly URL encoded when constructing GitHub API requests.

  • Apply encodeURIComponent() to path parameter in fetchRepoFiles method
  • Add unit test to verify proper encoding of paths with special characters

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

⚠️ No Changeset found

Latest commit: a1cf47a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchainjs-docs Ready Ready Preview Sep 5, 2025 7:14pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchainjs-api-refs Ignored Ignored Sep 5, 2025 7:14pm

Fix issue where directories with special characters (like '%5Fmeta')
would cause 404 errors because paths were not properly URL encoded
when constructing GitHub API requests.

- Apply encodeURIComponent() to path parameter in fetchRepoFiles method
- Add unit test to verify proper encoding of paths with special characters
@hntrl hntrl force-pushed the fix-github-loader-url-encoding branch from a22ebe9 to a1cf47a Compare September 5, 2025 18:57
@hntrl hntrl changed the base branch from main to hunter/fix/milvus-mocks September 5, 2025 18:58
@hntrl hntrl deleted the branch langchain-ai:hunter/fix/milvus-mocks September 5, 2025 18:59
@hntrl hntrl closed this Sep 5, 2025
@hntrl
Copy link
Member

hntrl commented Sep 5, 2025

not quite sure what happened here -- tried to rebase and github closed this. Continued on in #8860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants