Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI Generative AI tool calling bug fix #26910

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

OCI Generative AI tool calling bug fix #26910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8827cf3
fix streaming text repetition when tool callings
YouNeedCryDear Sep 12, 2024
85365d5
format text strings
YouNeedCryDear Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libs/community/langchain_community/chat_models/oci_generative_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ def chat_response_to_text(self, response: Any) -> str:

def chat_stream_to_text(self, event_data: Dict) -> str:
if "text" in event_data:
return event_data["text"]
if "finishedReason" in event_data or "toolCalls" in event_data:
return ""
else:
return event_data["text"]
Comment on lines +161 to +164
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if "finishedReason" in event_data or "toolCalls" in event_data:
return ""
else:
return event_data["text"]
return event_data.get("text")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efriis It is actually not a key error. It is the mechanism of our API. When finishedReason and toolCalls exists in the response, "text" field will output all the previous content generated and combine them together. This will make the streaming result to be duplicated two to three times.

else:
return ""

Expand Down
Loading