OCI Generative AI tool calling bug fix #26910
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
efriis
reviewed
Oct 3, 2024
Comment on lines
+161
to
+164
| if "finishedReason" in event_data or "toolCalls" in event_data: | ||
| return "" | ||
| else: | ||
| return event_data["text"] |
There was a problem hiding this comment.
Suggested change
| if "finishedReason" in event_data or "toolCalls" in event_data: | |
| return "" | |
| else: | |
| return event_data["text"] | |
| return event_data.get("text") |
There was a problem hiding this comment.
@efriis It is actually not a key error. It is the mechanism of our API. When finishedReason and toolCalls exists in the response, "text" field will output all the previous content generated and combine them together. This will make the streaming result to be duplicated two to three times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title:
"community: OCI Generative AI tool calling bug fix
PR message:
Add tests and docs: NA
Lint and test: make format, make lint and make test we run successfully