fix: properly skip fp16kernels if not enabled and allow building on ios #5866
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, even if fp16kernels was disabled via no-default-features, the feature check failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously even if
fp16kernelswas disabled, the check would still fail and cause a build failure when trying to build lance-linalg.The motivation was to enable building on
aarch64-apple-ios. This PR also adds support formtune=apple-a13when building for iOS, which is the earliest supported iOS architecture at time of writing.This is intended for merge to the 1.0 branch of lance. Let me know if its preferable to PR it to main and backport the change after.