Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates documentation for version 3 #51
Updates documentation for version 3 #51
Changes from all commits
d8683c4
42ce1db
b7d9e89
36c6e93
5ad842a
8e081ea
90adc25
714187e
1abb42a
41cf8d6
308870a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH: I would not encourage any1 in using the adapter plugin manager without fetching it from the container.
Main reason here is that some stuff might be registered to the plugin manager from container perspective.
Users are better off instantiating the adapter directly if they do not care about interchanging these.
IMHO, in 9/10 cases, its not even possible to swap serializers. We are using
igbinary
for almost 8+ years in combination with redis. There is no way of changing this without also changing namespace, etc.I'd say once a project decided to go with one serializer, that will be for like forever and thus having a direct instantiation will be a bit better I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only copied the content from the introduction, not changed it further: https://docs.laminas.dev/laminas-serializer/v3/intro/#quick-start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should encourage users to use
allowed_classes
for thePhpSerializer
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but I have only copied the content from the introduction, not changed it further.