Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates documentation for version 3 #51

Merged
merged 11 commits into from
Oct 4, 2023

Conversation

froschdesign
Copy link
Member

No description provided.

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
use Laminas\Serializer\Exception;
use Laminas\Serializer\Serializer;

$plugins = new AdapterPluginManager();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH: I would not encourage any1 in using the adapter plugin manager without fetching it from the container.
Main reason here is that some stuff might be registered to the plugin manager from container perspective.

Users are better off instantiating the adapter directly if they do not care about interchanging these.
IMHO, in 9/10 cases, its not even possible to swap serializers. We are using igbinary for almost 8+ years in combination with redis. There is no way of changing this without also changing namespace, etc.
I'd say once a project decided to go with one serializer, that will be for like forever and thus having a direct instantiation will be a bit better I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only copied the content from the introduction, not changed it further: https://docs.laminas.dev/laminas-serializer/v3/intro/#quick-start

```

INFO: **Defaults for PHP Serializer**
The PHP serializer does not have any defaults configured. If you want to modify the options of the `PhpSerializer` default, you will have to provide the config as shown above but with the `PhpSerializer` class and the options you want to use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should encourage users to use allowed_classes for the PhpSerializer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but I have only copied the content from the introduction, not changed it further.

Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure about those things I put a comment on.

@boesing boesing merged commit c4d6f89 into laminas:3.0.x Oct 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants