-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
You can also remove the public/ module and move the constants there to where they are used. |
// We should should consider reading all the information from the abi in the future. Right now we are not considering: | ||
// - type: "event" | ||
// - type: "struct" | ||
pub fn read_abi(abi_name: &PathBuf) -> HashMap<String, (usize, EntryPointType)> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im sure the cli
crate uses this function, and it will break once updated if we remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggest setting the starknet_in_rust
dependency in the cli
crate with a relative path to keep it up to date and prevent this kind of conflicts in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above comment
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 89.13% 89.09% -0.04%
==========================================
Files 51 50 -1
Lines 10069 10035 -34
==========================================
- Hits 8975 8941 -34
Misses 1094 1094
|
Closes #589