Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Remove unused modules #590

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Remove unused modules #590

merged 6 commits into from
Jun 6, 2023

Conversation

SantiagoPittella
Copy link
Collaborator

Closes #589

@juanbono
Copy link
Collaborator

juanbono commented Jun 5, 2023

You can also remove the public/ module and move the constants there to where they are used.

@SantiagoPittella SantiagoPittella changed the title Remove unused modules' Remove unused modules Jun 5, 2023
// We should should consider reading all the information from the abi in the future. Right now we are not considering:
// - type: "event"
// - type: "struct"
pub fn read_abi(abi_name: &PathBuf) -> HashMap<String, (usize, EntryPointType)> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im sure the cli crate uses this function, and it will break once updated if we remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest setting the starknet_in_rust dependency in the cli crate with a relative path to keep it up to date and prevent this kind of conflicts in the future

Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment

@SantiagoPittella SantiagoPittella requested a review from fmoletta June 6, 2023 13:52
@juanbono juanbono enabled auto-merge June 6, 2023 20:51
@juanbono juanbono added this pull request to the merge queue Jun 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #590 (113a3fc) into main (8f89001) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   89.13%   89.09%   -0.04%     
==========================================
  Files          51       50       -1     
  Lines       10069    10035      -34     
==========================================
- Hits         8975     8941      -34     
  Misses       1094     1094              
Impacted Files Coverage Δ
.../business_logic/execution/execution_entry_point.rs 96.83% <ø> (ø)
src/business_logic/state/cached_state.rs 93.27% <ø> (ø)
...ic/transaction/objects/internal_invoke_function.rs 98.94% <ø> (ø)
src/core/errors/state_errors.rs 100.00% <ø> (ø)
...calls/deprecated_business_logic_syscall_handler.rs 94.28% <ø> (ø)
src/runner/mod.rs 80.09% <ø> (ø)
.../api/contract_classes/deprecated_contract_class.rs 96.40% <ø> (ø)
src/storage/errors/storage_errors.rs 100.00% <ø> (ø)
src/serde_structs/mod.rs 100.00% <100.00%> (ø)

Merged via the queue into main with commit b794ac1 Jun 6, 2023
@juanbono juanbono deleted the delete-unused-modules branch June 14, 2023 20:12
@fmoletta fmoletta mentioned this pull request Jun 27, 2023
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused modules
4 participants