This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
rename crate to starknet_in_rust #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
reviewed
Jun 27, 2023
Cargo.toml
Outdated
Comment on lines
37
to
41
| starknet-contract-class = { path = "crates/starknet-contract-class" } | ||
| starknet-contract-class = "0.1.0" |
There was a problem hiding this comment.
Isn't it better to keep a relative path, as it is a crate within the same workspace?. This would make sure all crates are up to date and no breaking changes pop up later
There was a problem hiding this comment.
This can prevent issues such as this one: #590 (comment). Where code used by another crate was removed without any warning
There was a problem hiding this comment.
I tried to publish it with a relative path and it asked me to change it to a pinned version
There was a problem hiding this comment.
In cairo-rs we have both a path and a version specified for the felt package. Maybe that way it works?
MegaRedHand
approved these changes
Jun 27, 2023
fmoletta
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename crate to starknet_in_rust
Description
This PR renames the crate name to starknet in rust.
Checklist