Skip to content

Conversation

@jotabulacios
Copy link
Contributor

Fix Clippy

Description

This PR fixes all Clippy warnings for the latest Rust version

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.63%. Comparing base (055dc6f) to head (f033b03).

Files with missing lines Patch % Lines
crates/provers/stark/src/debug.rs 0.00% 3 Missing ⚠️
crates/provers/sumcheck/src/lib.rs 81.81% 2 Missing ⚠️
...field/fields/u32_montgomery_backend_prime_field.rs 0.00% 1 Missing ⚠️
...ates/provers/groth16/circom-adapter/src/readers.rs 0.00% 1 Missing ⚠️
crates/provers/sumcheck/src/prover.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   72.25%   69.63%   -2.63%     
==========================================
  Files         160      160              
  Lines       35620    32132    -3488     
==========================================
- Hits        25737    22374    -3363     
+ Misses       9883     9758     -125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotabulacios jotabulacios marked this pull request as ready for review August 1, 2025 20:54
@jotabulacios jotabulacios requested a review from a team as a code owner August 1, 2025 20:54
Copy link
Contributor

@ColoCarletti ColoCarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotabulacios jotabulacios added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit ad2a380 Aug 1, 2025
8 checks passed
@jotabulacios jotabulacios deleted the fix_clippy branch August 1, 2025 21:10
jotabulacios added a commit that referenced this pull request Aug 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2025
* save work, protocol structure now is following the post style

* add prints to debug implementation

* refactor to avoid unwraps

* more refactor

* more refactor

* refactor

* add readme

* Fix readme. Add struct Prover

* remove extra cargo.toml

* remove claimed_sum from sumcheck_proof. Fix test. Add documentation

* remove clones and fix clippy

* add documentation

* add check mark for gkr in readme

* add degree check on g_j

* add verifier checks: proof structure match circuit structure

* fix clippy for new rust version (#1013)

* fix clippy

* fix readme

* rename modulus

* avoid repetitive computation

* check terms has len 2

* remove clone term_1 and term_2

* add check number of inputs

* fix type complexity

---------

Co-authored-by: jotabulacios <jbulacios@fi.uba.ar>
Co-authored-by: jotabulacios <45471455+jotabulacios@users.noreply.github.com>
Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>
gabrielbosio pushed a commit that referenced this pull request Sep 23, 2025
* save work, protocol structure now is following the post style

* add prints to debug implementation

* refactor to avoid unwraps

* more refactor

* more refactor

* refactor

* add readme

* Fix readme. Add struct Prover

* remove extra cargo.toml

* remove claimed_sum from sumcheck_proof. Fix test. Add documentation

* remove clones and fix clippy

* add documentation

* add check mark for gkr in readme

* add degree check on g_j

* add verifier checks: proof structure match circuit structure

* fix clippy for new rust version (#1013)

* fix clippy

* fix readme

* rename modulus

* avoid repetitive computation

* check terms has len 2

* remove clone term_1 and term_2

* add check number of inputs

* fix type complexity

---------

Co-authored-by: jotabulacios <jbulacios@fi.uba.ar>
Co-authored-by: jotabulacios <45471455+jotabulacios@users.noreply.github.com>
Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants