-
Notifications
You must be signed in to change notification settings - Fork 179
fix clippy for new rust version #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+75
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 72.25% 69.63% -2.63%
==========================================
Files 160 160
Lines 35620 32132 -3488
==========================================
- Hits 25737 22374 -3363
+ Misses 9883 9758 -125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ColoCarletti
approved these changes
Aug 1, 2025
Contributor
ColoCarletti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pablodeymo
approved these changes
Aug 1, 2025
jotabulacios
added a commit
that referenced
this pull request
Aug 1, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
* save work, protocol structure now is following the post style * add prints to debug implementation * refactor to avoid unwraps * more refactor * more refactor * refactor * add readme * Fix readme. Add struct Prover * remove extra cargo.toml * remove claimed_sum from sumcheck_proof. Fix test. Add documentation * remove clones and fix clippy * add documentation * add check mark for gkr in readme * add degree check on g_j * add verifier checks: proof structure match circuit structure * fix clippy for new rust version (#1013) * fix clippy * fix readme * rename modulus * avoid repetitive computation * check terms has len 2 * remove clone term_1 and term_2 * add check number of inputs * fix type complexity --------- Co-authored-by: jotabulacios <jbulacios@fi.uba.ar> Co-authored-by: jotabulacios <45471455+jotabulacios@users.noreply.github.com> Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>
gabrielbosio
pushed a commit
that referenced
this pull request
Sep 23, 2025
* save work, protocol structure now is following the post style * add prints to debug implementation * refactor to avoid unwraps * more refactor * more refactor * refactor * add readme * Fix readme. Add struct Prover * remove extra cargo.toml * remove claimed_sum from sumcheck_proof. Fix test. Add documentation * remove clones and fix clippy * add documentation * add check mark for gkr in readme * add degree check on g_j * add verifier checks: proof structure match circuit structure * fix clippy for new rust version (#1013) * fix clippy * fix readme * rename modulus * avoid repetitive computation * check terms has len 2 * remove clone term_1 and term_2 * add check number of inputs * fix type complexity --------- Co-authored-by: jotabulacios <jbulacios@fi.uba.ar> Co-authored-by: jotabulacios <45471455+jotabulacios@users.noreply.github.com> Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Clippy
Description
This PR fixes all Clippy warnings for the latest Rust version