Add GKR Protocol #1011
Merged
Add GKR Protocol #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 69.63% 70.17% +0.54%
==========================================
Files 160 165 +5
Lines 32132 32770 +638
==========================================
+ Hits 22374 22996 +622
- Misses 9758 9774 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jotabulacios
force-pushed
the
gkr_protocol
branch
from
e5d7ac2 to
55f0f95
Compare
pablodeymo
reviewed
Aug 29, 2025
crates/provers/gkr/src/lib.rs
Outdated
Comment on lines
81
to
83
| const MODULUS: u64 = 389; | ||
| type F = U64PrimeField<MODULUS>; | ||
| type FE = FieldElement<F>; |
Contributor
There was a problem hiding this comment.
I would suggest to add the suffix to these constants as in MODULUS23, F23 and F23E
pablodeymo
reviewed
Aug 29, 2025
crates/provers/gkr/src/prover.rs
Outdated
Comment on lines
82
to
83
| for c_idx in 0..(1 << num_vars_next) { | ||
| for b_idx in 0..(1 << num_vars_next) { |
Contributor
There was a problem hiding this comment.
it's better to assign this: 1 << num_vars_next to a new variable to avoid repetitive computation
pablodeymo
reviewed
Aug 29, 2025
crates/provers/gkr/src/sumcheck.rs
Outdated
Comment on lines
39
to
40
| let factors_term_1 = terms[0].clone(); | ||
| let factors_term_2 = terms[1].clone(); |
Contributor
There was a problem hiding this comment.
this function should check that terms has at least 2 elements
Contributor
Author
There was a problem hiding this comment.
Thanks! Done it here.
We also remove the terms[0].is_empty part, because Prover::new() already checks that.
pablodeymo
reviewed
Aug 29, 2025
crates/provers/gkr/src/sumcheck.rs
Outdated
| return Err(ProverError::SumcheckError); | ||
| } | ||
|
|
||
| let factors_term_1 = terms[0].clone(); |
Contributor
There was a problem hiding this comment.
the clone is not necessary, since this function takes ownership of the Vec
diegokingston
approved these changes
Sep 4, 2025
pablodeymo
approved these changes
Sep 4, 2025
gabrielbosio
pushed a commit
that referenced
this pull request
Sep 23, 2025
* save work, protocol structure now is following the post style * add prints to debug implementation * refactor to avoid unwraps * more refactor * more refactor * refactor * add readme * Fix readme. Add struct Prover * remove extra cargo.toml * remove claimed_sum from sumcheck_proof. Fix test. Add documentation * remove clones and fix clippy * add documentation * add check mark for gkr in readme * add degree check on g_j * add verifier checks: proof structure match circuit structure * fix clippy for new rust version (#1013) * fix clippy * fix readme * rename modulus * avoid repetitive computation * check terms has len 2 * remove clone term_1 and term_2 * add check number of inputs * fix type complexity --------- Co-authored-by: jotabulacios <jbulacios@fi.uba.ar> Co-authored-by: jotabulacios <45471455+jotabulacios@users.noreply.github.com> Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GKR Protocol
Description
An implementation of the Goldwasser-Kalai-Rothblum (GKR) Non-Interactive Protocol for proving correct evaluation of arithmetic circuits.
This implementation follows the steps described in our blog post.
Warning: This GKR implementation is for educational purposes and should not be used in production. It uses the Fiat-Shamir transform, which is vulnerable to practical attacks in this context (see "How to Prove False Statments").
Type of change
Please delete options that are not relevant.