feat: eth_newPayloadV3: fetch cancun time from db for timestamp validation
#220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
Aug 5, 2024
crates/storage/storage.rs
Outdated
|
|
||
| // Store chain info | ||
| if let Some(cancun_time) = genesis.config.cancun_time { | ||
| self.update_cancun_time(cancun_time)?; |
Collaborator
There was a problem hiding this comment.
these values are set once. Wouldn't it make more sense to have a function like set_chain_spec that sets these values the first time? All these values shouldn't be updatable.
mpaulucci
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fetch cancun time from DB when validating payload v3 timestamp
Description
eth_newPayloadV3Storewithset_chain_configBonus:
NewPayloadV3Requestto its corresponding module and update is parsing to match the rest of the codebaseCloses None, but is part of #51