Skip to content

Add method HTMLBlob for more streamlined / less allocating renders. #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add method HTMLBlob for more streamlined / less allocating renders. #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
daed69f
Since some templating engines final result is a buffer, we've been ca…
RyanCopley Dec 5, 2016
d2e600b
Since some templating engines final result is a buffer, we've been ca…
RyanCopley Dec 5, 2016
adb05c8
--
RyanCopley Dec 5, 2016
be7df46
Update context.go
RyanCopley Dec 6, 2016
2dff901
Update context_test.go
RyanCopley Dec 6, 2016
a5526e6
Update context_test.go
RyanCopley Dec 6, 2016
0d6e1e5
Utilize same design pattern for HTMLBlob as JSONBlob
RyanCopley Dec 6, 2016
ceac2dd
Streamlined a few more methods
RyanCopley Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ type (
// HTML sends an HTTP response with status code.
HTML(int, string) error

// HTMLBlob sends an HTTP blob response with status code.
HTMLBlob(int, []byte) error

// String sends a string response with status code.
String(int, string) error

Expand Down Expand Up @@ -356,17 +359,15 @@ func (c *context) Render(code int, name string, data interface{}) (err error) {
}

func (c *context) HTML(code int, html string) (err error) {
c.response.Header().Set(HeaderContentType, MIMETextHTMLCharsetUTF8)
c.response.WriteHeader(code)
_, err = c.response.Write([]byte(html))
return
return c.Blob(code, MIMETextHTMLCharsetUTF8, []byte(html))
}

func (c *context) HTMLBlob(code int, b []byte) (err error) {
return c.Blob(code, MIMETextHTMLCharsetUTF8, b)
}

Copy link
Member

@vishr vishr Dec 6, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also modify HTML to use HTMLBlob like in JSON. With that you don't need your test case as it will be already covered - just for consistency.

func (c *context) String(code int, s string) (err error) {
c.response.Header().Set(HeaderContentType, MIMETextPlainCharsetUTF8)
c.response.WriteHeader(code)
_, err = c.response.Write([]byte(s))
return
return c.Blob(code, MIMETextPlainCharsetUTF8, []byte(s))
}

func (c *context) JSON(code int, i interface{}) (err error) {
Expand Down
10 changes: 10 additions & 0 deletions context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,16 @@ func TestContext(t *testing.T) {
assert.Equal(t, "Hello, <strong>World!</strong>", rec.Body.String())
}

// HTMLBlob
rec = httptest.NewRecorder()
c = e.NewContext(req, rec).(*context)
err = c.HTMLBlob(http.StatusOK, []byte("Hello, <strong>World!</strong>"))
if assert.NoError(t, err) {
assert.Equal(t, http.StatusOK, rec.Code)
assert.Equal(t, MIMETextHTMLCharsetUTF8, rec.Header().Get(HeaderContentType))
assert.Equal(t, "Hello, <strong>World!</strong>", rec.Body.String())
}

// Stream
rec = httptest.NewRecorder()
c = e.NewContext(req, rec).(*context)
Expand Down