Add method HTMLBlob for more streamlined / less allocating renders. #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCopley
force-pushed
the
master-allow-html-buffers
branch
from
460b525 to
9f034c2
Compare
…sting them to strings, which is a bit unnecessary considering under the hood Echo supports this.
RyanCopley
force-pushed
the
master-allow-html-buffers
branch
from
9e9676c to
daed69f
Compare
…sting them to strings, which is a bit unnecessary considering under the hood Echo supports this.
Member
|
@RyanCopley You can use |
Author
|
Ah-- blob is the word I should've looked for. That wouldn't set the content-type, and there is both an |
RyanCopley
changed the title
Member
|
@RyanCopley You can set content type in |
Author
|
Absolutely! |
vishr
reviewed
Dec 6, 2016
| func (c *context) HTMLBlob(code int, b []byte) (err error) { | ||
| return c.Blob(code, MIMETextHTMLCharsetUTF8, b) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
You can also modify HTML to use HTMLBlob like in JSON. With that you don't need your test case as it will be already covered - just for consistency.
Author
|
@vishr Done :) |
Member
|
Closed in #765 |
Member
|
Thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey echo maintenance! 👋
We're utilizing Echo in a project and I'm trying to clean up some of our project. I noticed that we're converting bytes.Buffer's into strings, then back to a byte array. That seems a little bit much just to move some text around so I thought it'd be nice if there was a method that directly accepts bytes.Buffers (which this package already imports, thankfully!)
Since some templating (I'm looking at you, pongo2) engines final result is a buffer, we've been casting them to strings, which is a bit unnecessary considering under the hood Echo supports this.
Let me know if you have any questions:)