Remove unused imports/PY2 compat, check_version() calls, and implement graceful ctrl-c handling #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t graceful ctrl-c handling labscript-suite/labscript-utils#45 removes labconfig.config_prefix which we were importing but not using, so we need to remove it. We can remove all version checks as they are now handled by packaging tools. Implement the standard way of ensuring a PyQt application shuts down cleanly upon ctrl-C.
Loki27182
pushed a commit
to Loki27182/runviewer
that referenced
this pull request
Oct 9, 2023
Restructure into standard Python package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labscript-suite/labscript-utils#45 removes
labconfig.config_prefixwhich we were importing but not using, so we need to remove it. Also removed other unused imports noticed by my linter.Remove all version checks as they are now handled by packaging tools.
Implement the standard way of ensuring a PyQt application shuts down cleanly upon ctrl-c.