Remove pre-compiled resample extension #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjbillington
force-pushed
the
no-precompiled-extension
branch
from
1004cc1 to
2358c5d
Compare
chrisjbillington
added a commit
to chrisjbillington/runviewer
that referenced
this pull request
May 23, 2020
Include only the source in the git repository. Modify setup.py to be able to build the extension.
chrisjbillington
force-pushed
the
no-precompiled-extension
branch
from
2358c5d to
5c920c8
Compare
The extension lives directly in runviewer/
Now `pip install -e` will know to install cython (in the isolated build environment) before running setup.py
And uncomment test uploads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include only the source in the git repository.
Modify setup.py to be able to build the extension.
Include Cython as a setup_requires requirement.