Refactor Application Gateway to expose authorisation related code #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akgalwas
requested review from
crabtree,
franpog859,
janmedrek,
Maladie and
Szymongib
as code owners
|
/test pre-master-kyma-components-application-gateway |
…ntials" This reverts commit d96f516.
Szymongib
reviewed
Jul 4, 2019
| // Headers that are injected by the gateway | ||
| Headers *map[string][]string | ||
| // QueryParameters that are injected by the gateway | ||
| QueryParameters *map[string][]string |
There was a problem hiding this comment.
As discussed Headers and QueryParameters are leftovers and we should remove those.
|
/test all |
Szymongib
approved these changes
Jul 5, 2019
Szymongib
added
area/application-connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)