-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codegen in installer component #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crabtree
requested review from
jakkab,
strekm and
Tomasz-Smelcerz-SAP
as code owners
July 25, 2018 05:41
strekm
approved these changes
Jul 25, 2018
janmedrek
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Refactoring: added fields for storing basic auth credentials * Refactoring: started implementing new approach to authorization * Refactoring: implemented new version of retrier * Refactoring: added strategy factory, moved oauth client to authorization package, started refactoring proxy * Refactoring: next steps in refactoring proxy * Refactoring: HttpCache and NameResolver is no longer injected * Refactoring: implemented proxying using StrategyFactory, need to add retry functionality * Refactoring: added retry functionality * Refactoring: minor cleanup * Refactoring: package renamed * Refactoring: cache test rewritten * Refactoring: unit tests for authorization package written * Refactoring: fixed issue in ForbiddenRequestRetrier and added checking if proxy uses internal cache * Refactoring: bumped RE client version and updated code to reflect changes in RE * Refactoring: fixed serviceapiservice test * Added basic auth plus some code formatting * Minor clean up * Refactoring: renamed methods in Strategy interface * Minor cleanup * Fixed issue with namespace flag * Retry is performed when 401 o3 403 status has been returned * Issue with logging fixed * Code review #1 * Code review #2 * Code review #3 * Code review #4 * Typo fixed * Minor refactoring * Code review #5 * Code review #6
m00g3n
added a commit
that referenced
this pull request
Mar 21, 2019
* Add query and subscription for k8s services * rename graphQL type KService to Service * add integration tests * rebase to rename * code review comments addressed * code review comments addressed * Add mutation * add mutation #2 * add mutation #3 * add mutation #4 * Align error handling introduced in #2968 * import reorganization; rbac-test-console-backend-service reverted * build trigger
m00g3n
added a commit
that referenced
this pull request
Mar 21, 2019
anishj0shi
added a commit
to anishj0shi/kyma
that referenced
this pull request
Jul 19, 2019
anishj0shi
added a commit
to anishj0shi/kyma
that referenced
this pull request
Jul 24, 2019
m00g3n
referenced
this pull request
in m00g3n/kyma
Mar 27, 2020
m00g3n
referenced
this pull request
in m00g3n/kyma
Mar 27, 2020
m00g3n
referenced
this pull request
in m00g3n/kyma
Apr 1, 2020
ksputo
added a commit
to ksputo/kyma
that referenced
this pull request
Nov 5, 2020
grischperl
referenced
this pull request
in grischperl/kyma
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm these statements before you submit your pull request:
Description
Changes proposed in this pull request: