Fix reconnectionError not emittend when authenticator is missing #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #664 +/- ##
==========================================
+ Coverage 85.68% 85.95% +0.26%
==========================================
Files 36 36
Lines 1712 1716 +4
Branches 311 314 +3
==========================================
+ Hits 1467 1475 +8
+ Misses 183 179 -4
Partials 62 62
Continue to review full report at Codecov.
|
Aschen
approved these changes
Sep 20, 2021
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Aschen
approved these changes
Sep 21, 2021
Aschen
added a commit
that referenced
this pull request
Sep 21, 2021
# [7.7.6](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.7.6) (2021-09-21) #### Enhancements - [ [#663](#663) ] Convert Security Controller to Typescript ([inform880](https://github.com/inform880)) #### Bug fixes - [ [#664](#664) ] Fix reconnectionError not emittend when authenticator is missing ([Shiranuit](https://github.com/Shiranuit)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Emit a reconnectionError when there is no authenticator set.