Convert Security Controller to Typescript #663
Conversation
There was a problem hiding this comment.
Thanks for your contribution!
Can you remove the original SecurityController.js file from the repo since it's a generated file now please?
Also, you should add this file to the .eslintignore and .gitignore files.
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 85.94% 83.40% -2.54%
==========================================
Files 36 36
Lines 1715 1766 +51
Branches 314 324 +10
==========================================
- Hits 1474 1473 -1
- Misses 179 227 +48
- Partials 62 66 +4
Continue to review full report at Codecov.
|
|
@Aschen Do I have to worry about some of the checks failing, not sure if I have more changes I have to make? |
No it's because your PR came from a fork so the of the secrets we are using in our CI are not present. |
Aschen
changed the title
# [7.7.6](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.7.6) (2021-09-21) #### Enhancements - [ [#663](#663) ] Convert Security Controller to Typescript ([inform880](https://github.com/inform880)) #### Bug fixes - [ [#664](#664) ] Fix reconnectionError not emittend when authenticator is missing ([Shiranuit](https://github.com/Shiranuit)) ---
2 participants
What does this PR do ?
This PR converts the security.js to a TypeScript file in order to get autocompletion.
How should this be manually tested?
Other changes
Boyscout