Fix large document search using scroll #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to ES documentation, `scroll` parameter should be sent again with `_search/scroll` api call, allowing us to choose smallest timeout for scroll to live on.
Yoann-Abbes
approved these changes
Jun 3, 2019
alexandrebouthinon
approved these changes
Jun 3, 2019
|
@stafyniaksacha Can you fix the unit tests please ? I will merge it after |
benoitvidis
approved these changes
Jun 4, 2019
|
@Aschen should be ok |
Codecov Report
@@ Coverage Diff @@
## 6-dev #400 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 32 32
Lines 1519 1519
=======================================
Hits 1463 1463
Misses 56 56
Continue to review full report at Codecov.
|
scottinet
approved these changes
Jun 5, 2019
Merged
Aschen
added a commit
that referenced
this pull request
Jun 14, 2019
Release 6.1.2
Bug fixes
[ #398 ] Fix bulk return (Aschen)
[ #394 ] Add default values for from/size to document:search (Aschen)
[ #384 ] Fix search API: "sort" and "search_after" must be in the requests body (scottinet)
Enhancements
[ #390 ] Add authenticated property on Kuzzle object (Aschen)
[ #395 ] Proxify kuzzle to avoid mistyping error (thomasarbona)
[ #389 ] Remove usage of _meta (Aschen)
[ #391 ] Add isConnected (Aschen)
[ #388 ] Use BaseController class for controllers (Aschen)
[ #385 ] Add Security.createRestrictedUser method (Aschen)
Others
[ #400 ] Fix large document search using scroll (stafyniaksacha)
[ #387 ] SearchResult.next returns a new instance (Aschen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
According to ES documentation,
scrollparameter should be sent again with_search/scrollapi call, allowing us to choose smallest timeout for scroll to live on.