Skip to content

Conversation

@Aschen
Copy link
Contributor

@Aschen Aschen commented Apr 29, 2019

What does this PR do?

Add getter to know if the SDK is connected to a Kuzzle server or not.

This getter is just a wrapper around the connected getter of the underlying protocol.

kuzzle.connected //=> true

@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #391 into 6-dev will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##            6-dev     #391      +/-   ##
==========================================
- Coverage   96.65%   96.45%   -0.21%     
==========================================
  Files          30       30              
  Lines        1437     1440       +3     
==========================================
  Hits         1389     1389              
- Misses         48       51       +3
Impacted Files Coverage Δ
src/Kuzzle.js 95.02% <0%> (-0.44%) ⬇️
src/protocols/http.js 92.4% <0%> (-1.19%) ⬇️
src/protocols/abstract/common.js 88.88% <0%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72279cc...e69b4f0. Read the comment docs.

Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already covered by the state Protocol property?

@Yoann-Abbes Yoann-Abbes merged commit f699c3b into 6-dev May 7, 2019
@Yoann-Abbes Yoann-Abbes deleted the add-isConnected branch May 7, 2019 07:05
@Aschen Aschen mentioned this pull request Jun 14, 2019
Aschen added a commit that referenced this pull request Jun 14, 2019
Release 6.1.2

Bug fixes

    [ #398 ] Fix bulk return (Aschen)
    [ #394 ] Add default values for from/size to document:search (Aschen)
    [ #384 ] Fix search API: "sort" and "search_after" must be in the requests body (scottinet)

Enhancements

    [ #390 ] Add authenticated property on Kuzzle object (Aschen)
    [ #395 ] Proxify kuzzle to avoid mistyping error (thomasarbona)
    [ #389 ] Remove usage of _meta (Aschen)
    [ #391 ] Add isConnected (Aschen)
    [ #388 ] Use BaseController class for controllers (Aschen)
    [ #385 ] Add Security.createRestrictedUser method (Aschen)

Others

    [ #400 ] Fix large document search using scroll (stafyniaksacha)
    [ #387 ] SearchResult.next returns a new instance (Aschen)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants