- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
Add isConnected #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isConnected #391
Conversation
| Codecov Report
 @@            Coverage Diff             @@
##            6-dev     #391      +/-   ##
==========================================
- Coverage   96.65%   96.45%   -0.21%     
==========================================
  Files          30       30              
  Lines        1437     1440       +3     
==========================================
  Hits         1389     1389              
- Misses         48       51       +3
 Continue to review full report at Codecov. 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already covered by the state Protocol property?
Release 6.1.2
Bug fixes
    [ #398 ] Fix bulk return (Aschen)
    [ #394 ] Add default values for from/size to document:search (Aschen)
    [ #384 ] Fix search API: "sort" and "search_after" must be in the requests body (scottinet)
Enhancements
    [ #390 ] Add authenticated property on Kuzzle object (Aschen)
    [ #395 ] Proxify kuzzle to avoid mistyping error (thomasarbona)
    [ #389 ] Remove usage of _meta (Aschen)
    [ #391 ] Add isConnected (Aschen)
    [ #388 ] Use BaseController class for controllers (Aschen)
    [ #385 ] Add Security.createRestrictedUser method (Aschen)
Others
    [ #400 ] Fix large document search using scroll (stafyniaksacha)
    [ #387 ] SearchResult.next returns a new instance (Aschen)
    
What does this PR do?
Add getter to know if the SDK is connected to a Kuzzle server or not.
This getter is just a wrapper around the
connectedgetter of the underlying protocol.kuzzle.connected //=> true