Skip to content

Conversation

@Aschen
Copy link
Contributor

@Aschen Aschen commented Jun 21, 2019

What does this PR do ?

⚠️ Do not merge this PR, I based the PR on the previous branch for better diff readability

Adds unit tests for Kuzzle class

How should this be manually tested?

  • Step 1 : Run dotnet test

Other changes

  • Change some methods or attribute visibility to internal

@Aschen Aschen self-assigned this Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #17 into fix-optional-parameters-design will increase coverage by 13.5%.
The diff coverage is 100%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           fix-optional-parameters-design      #17      +/-   ##
==================================================================
+ Coverage                           30.25%   43.75%   +13.5%     
==================================================================
  Files                                  17       20       +3     
  Lines                                 876     1065     +189     
  Branches                              105      145      +40     
==================================================================
+ Hits                                  265      466     +201     
+ Misses                                610      591      -19     
- Partials                                1        8       +7
Impacted Files Coverage Δ
Kuzzle/Kuzzle.cs 86.53% <100%> (+86.53%) ⬆️
Kuzzle/Exceptions/InternalException.cs 100% <100%> (ø)
Kuzzle/API/Options/SearchOptions.cs 100% <0%> (ø) ⬆️
Kuzzle/API/Controllers/AuthController.cs 100% <0%> (ø) ⬆️
Kuzzle/API/Options/ListOptions.cs 16.66% <0%> (ø)
Kuzzle/API/Options/DocumentOptions.cs 0% <0%> (ø)
Kuzzle/API/Controllers/DocumentController.cs 0.68% <0%> (+0.68%) ⬆️
Kuzzle/API/Controllers/ServerController.cs 1.92% <0%> (+1.92%) ⬆️
Kuzzle/Protocol/AbstractProtocol.cs 14.28% <0%> (+14.28%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6372c3b...b8c0ffb. Read the comment docs.

@scottinet scottinet changed the base branch from unit-tests-collection-controller to fix-optional-parameters-design June 21, 2019 12:07
@scottinet scottinet merged commit 926d6e1 into fix-optional-parameters-design Jun 26, 2019
@scottinet scottinet deleted the unit-tests-kuzzle-class branch June 26, 2019 11:59
@scottinet scottinet mentioned this pull request Jul 17, 2019
scottinet added a commit that referenced this pull request Jul 18, 2019
# [0.2.0](https://github.com/kuzzleio/sdk-csharp/releases/tag/0.2.0) (2019-07-17)


#### New features

- [ [#22](#22) ] Add Admin controller and unit tests   ([Shiranuit](https://github.com/Shiranuit))
- [ [#23](#23) ] Add Index Controller   ([alexandrebouthinon](https://github.com/alexandrebouthinon))

#### Enhancements

- [ [#14](#14) ] Fix optional parameters design   ([scottinet](https://github.com/scottinet))
- [ [#13](#13) ] Add unit tests for the collection controller   ([scottinet](https://github.com/scottinet))
- [ [#12](#12) ] Add unit tests for the auth controller   ([scottinet](https://github.com/scottinet))
- [ [#11](#11) ] Initialize unit tests project   ([scottinet](https://github.com/scottinet))

#### Others

- [ [#24](#24) ] Rewrite WebSocket class   ([scottinet](https://github.com/scottinet), [alexandrebouthinon](https://github.com/alexandrebouthinon))
- [ [#20](#20) ] Add documentation runner   ([Aschen](https://github.com/Aschen))
- [ [#18](#18) ] Add unit test for Realtime Controller    ([ThomasF34](https://github.com/ThomasF34))
- [ [#17](#17) ] Unit tests kuzzle class   ([Aschen](https://github.com/Aschen))
- [ [#16](#16) ] Add unit tests for the server controller   ([ThomasF34](https://github.com/ThomasF34))
- [ [#15](#15) ] Add unit tests for the document controller   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants