Skip to content

Conversation

@scottinet
Copy link
Contributor

@scottinet scottinet commented Jun 11, 2019

Description

Initialize unit tests on this repo, with a bit of tooling, code coverage calculation and reporting.

Necessary refactor: API controller now receive a Kuzzle API interface (IKuzzleApi) instead of a Kuzzle instance, because mocking can only be done with interfaces or abstract classes.

⚠️ this project cannot be built nor tested using monodevelop due to current compatibility problems between dotnet-core and msbuild. Read the README documentation to build this SDK from the CLI.
See NuGet/Home#7956

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (0-dev@d55b852). Click here to learn what that means.
The diff coverage is 8.64%.

Impacted file tree graph

@@           Coverage Diff           @@
##             0-dev     #11   +/-   ##
=======================================
  Coverage         ?   3.45%           
=======================================
  Files            ?      19           
  Lines            ?     898           
  Branches         ?     107           
=======================================
  Hits             ?      31           
  Misses           ?     866           
  Partials         ?       1
Impacted Files Coverage Δ
Kuzzle/API/Controllers/ServerController.cs 0% <0%> (ø)
Kuzzle/API/DataObjects/SearchResults.cs 0% <0%> (ø)
Kuzzle/API/Controllers/RealtimeController.cs 0% <0%> (ø)
Kuzzle/API/Controllers/DocumentController.cs 0% <0%> (ø)
Kuzzle/Kuzzle.cs 0% <0%> (ø)
Kuzzle/API/Controllers/CollectionController.cs 0% <0%> (ø)
Kuzzle/API/Controllers/BaseController.cs 100% <100%> (ø)
Kuzzle/API/Controllers/AuthController.cs 15.26% <21.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55b852...33ed7c8. Read the comment docs.

@scottinet scottinet changed the base branch from master to 0-dev June 12, 2019 07:49
Copy link
Contributor

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

@scottinet scottinet merged commit e56f553 into 0-dev Jun 18, 2019
@scottinet scottinet deleted the unit-tests branch June 18, 2019 07:41
@scottinet scottinet mentioned this pull request Jul 17, 2019
scottinet added a commit that referenced this pull request Jul 18, 2019
# [0.2.0](https://github.com/kuzzleio/sdk-csharp/releases/tag/0.2.0) (2019-07-17)


#### New features

- [ [#22](#22) ] Add Admin controller and unit tests   ([Shiranuit](https://github.com/Shiranuit))
- [ [#23](#23) ] Add Index Controller   ([alexandrebouthinon](https://github.com/alexandrebouthinon))

#### Enhancements

- [ [#14](#14) ] Fix optional parameters design   ([scottinet](https://github.com/scottinet))
- [ [#13](#13) ] Add unit tests for the collection controller   ([scottinet](https://github.com/scottinet))
- [ [#12](#12) ] Add unit tests for the auth controller   ([scottinet](https://github.com/scottinet))
- [ [#11](#11) ] Initialize unit tests project   ([scottinet](https://github.com/scottinet))

#### Others

- [ [#24](#24) ] Rewrite WebSocket class   ([scottinet](https://github.com/scottinet), [alexandrebouthinon](https://github.com/alexandrebouthinon))
- [ [#20](#20) ] Add documentation runner   ([Aschen](https://github.com/Aschen))
- [ [#18](#18) ] Add unit test for Realtime Controller    ([ThomasF34](https://github.com/ThomasF34))
- [ [#17](#17) ] Unit tests kuzzle class   ([Aschen](https://github.com/Aschen))
- [ [#16](#16) ] Add unit tests for the server controller   ([ThomasF34](https://github.com/ThomasF34))
- [ [#15](#15) ] Add unit tests for the document controller   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants