feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes #11107

jijiechen · 2024-08-13T05:24:50Z

Checklist prior to review

Link to relevant issue as well as docs and UI issues
- fixes Improve kuma-dp probe #11034
This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
- Confirmed
Tests (Unit test, E2E tests, manual test on universal and k8s)
- Added
- Don't forget ci/ labels to run additional/fewer tests
Do you need to update UPGRADE.md?
- No
Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: feat(kuma-dp): respond probes of kuma-sidecar from kuma-dp process instead of Envoy

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

…ager Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

This reverts commit d1e2f8a.

This reverts commit 0fe11a9.

pkg/xds/generator/admin_proxy_generator.go

app/kuma-dp/pkg/dataplane/readiness/component.go

pkg/xds/generator/admin_proxy_generator.go

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

slonka

Just one nitpick. Once you check universal + 2 dpps feel free to merge it

app/kuma-dp/pkg/dataplane/readiness/component.go

jijiechen · 2024-08-23T09:59:58Z

I believe the CI failures are caused by image pulling issues that can recover in a different time.
It seems there is something with docker hub, they are not able to serve the image pulling at this time.
I've re-run the failed cases on my local machine and they passed. The cases are "CP - upgrading" scenarios which are not relevant to the changes in this PR.

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

github-actions · 2024-08-28T07:22:21Z

backporting to release-2.8 with action

backporting to release-2.4 with action
backporting to release-2.6 with action
backporting to release-2.7 with action

…ess probes (#11107) * feat(kuma-dp): add a readiness handler * feat(kuma-dp): support TERMINATING state * use 9902 to expose dp readiness * support port 0 to disable the dp readiness and use Envoy * support ipv6 address: reuse AdminAddress and make readiness reporter listen on it * don't send 503 when receiving SIGUSR2 --------- Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

…ess probes (backport of #11107) (#11242)

…ess probes (backport of #11107) (#11238)

…ess probes (backport of #11107) (#11241)

…ess probes (backport of #11107) (#11239)

lahabana · 2024-09-10T07:33:56Z

pkg/xds/envoy/names/resource_names.go

@@ -65,6 +65,10 @@ func GetMetricsHijackerClusterName() string {
 	return Join("kuma", "metrics", "hijacker")
 }

+func GetDPPReadinessClusterName() string {
+	return Join("kuma", "readiness")


That's an internal cluster it should have _ prefix like https://github.com/kumahq/kuma/blob/master/docs/madr/decisions/036-internal-listeners.md

… dataplane-token (#11849) ## Motivation fixes #11848  ## Implementation information Mark the option as required. Includes a small fixes that resolves #11107 (comment) ## Supporting documentation  fixes #11848   --------- Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

jijiechen added 5 commits August 12, 2024 14:56

feat(kuma-dp): add a readiness handler

8c87568

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

feat(kuma-dp): add the readiness component into kuma-dp component man…

f799732

…ager Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

feat(kuma-dp): support TERMINATING state

2e82fc4

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

feat(kuma-dp): forward to readiness socket by xDS

92556dd

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

feat(kuma-dp): add Cache-Control and X-Readiness-Server response header

b9bde91

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

jijiechen assigned jakubdyszkiewicz and lobkovilya Aug 13, 2024

jijiechen requested a review from a team as a code owner August 13, 2024 05:24

jijiechen requested review from slonka and lobkovilya and removed request for a team August 13, 2024 05:24

jijiechen unassigned jakubdyszkiewicz and lobkovilya Aug 13, 2024

feat(kuma-dp): fix lint format errors

58007ed

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

jijiechen force-pushed the sidecar-readiness branch from bda4bb8 to 58007ed Compare August 13, 2024 06:58

jijiechen changed the title ~~feat(kuma-dp): add a separate readiness component to handle dataplane health probes~~ feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes Aug 13, 2024

jijiechen added 6 commits August 15, 2024 10:30

Merge branch 'master' into sidecar-readiness

ac48971

use atomic boolean in readiness

7dccf9c

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

probe envoy readiness

0fe11a9

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

added envoy stats tests

d1e2f8a

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

Revert "added envoy stats tests"

f10b778

This reverts commit d1e2f8a.

Revert "probe envoy readiness"

8e67d52

This reverts commit 0fe11a9.

lukidzi reviewed Aug 19, 2024

View reviewed changes

pkg/xds/generator/admin_proxy_generator.go Outdated Show resolved Hide resolved

slonka reviewed Aug 20, 2024

View reviewed changes

app/kuma-dp/pkg/dataplane/readiness/component.go Outdated Show resolved Hide resolved

app/kuma-dp/pkg/dataplane/readiness/component.go Outdated Show resolved Hide resolved

pkg/xds/generator/admin_proxy_generator.go Outdated Show resolved Hide resolved

jijiechen mentioned this pull request Aug 20, 2024

feat(kuma-dp): statically respond readiness of Envoy as READY #11145

Closed

5 tasks

jijiechen added 4 commits August 21, 2024 15:17

use 9902 to expose dp readiness

58205ea

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

support port 0 to disable the dp readiness and use Envoy

fcc2175

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

updated unit tests

290207c

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

fix metadata value types for readiness port

c3d6973

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

jijiechen force-pushed the sidecar-readiness branch from 779b3d2 to c78a981 Compare August 21, 2024 08:06

slonka approved these changes Aug 23, 2024

View reviewed changes

app/kuma-dp/pkg/dataplane/readiness/component.go Show resolved Hide resolved

jijiechen enabled auto-merge (squash) August 23, 2024 10:03

jijiechen added 5 commits August 26, 2024 11:13

try to debug e2e using SSH

1b4083c

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>

remote ssh step in e2e: be prepared for merge master

4003c1c

Merge branch 'master' into sidecar-readiness

593bacd

add remote ssh step in e2e

387a319

increase numbers of images allowed in k3d

8d58040

jijiechen merged commit 20208eb into kumahq:master Aug 28, 2024
35 checks passed

bartsmykla mentioned this pull request Aug 28, 2024

ci(k3d): disable image garbage collection #11235

Closed

5 tasks

jijiechen added the backport label Aug 28, 2024

kumahq bot mentioned this pull request Aug 28, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes (backport of #11107) #11241

Merged

kumahq bot mentioned this pull request Aug 28, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes (backport of #11107) #11242

Merged

jijiechen pushed a commit that referenced this pull request Aug 30, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readin…

ab8e746

…ess probes (backport of #11107) (#11242)

jijiechen pushed a commit that referenced this pull request Aug 30, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readin…

e21c751

…ess probes (backport of #11107) (#11238)

jijiechen pushed a commit that referenced this pull request Aug 30, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readin…

2fc072e

…ess probes (backport of #11107) (#11241)

jijiechen pushed a commit that referenced this pull request Aug 30, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readin…

4f178cd

…ess probes (backport of #11107) (#11239)

lahabana reviewed Sep 10, 2024

View reviewed changes

BrewTestBot mentioned this pull request Oct 22, 2024

kumactl 2.9.0 Homebrew/homebrew-core#195202

Merged

jijiechen mentioned this pull request Oct 24, 2024

fix(kumactl): mark valid-for as required for command kumactl generate dataplane-token #11849

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes #11107

feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes #11107

jijiechen commented Aug 13, 2024 •

edited

Loading

slonka left a comment

jijiechen commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

lahabana Sep 10, 2024

feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes #11107

feat(kuma-dp): add a separate component to handle kuma-sidecar readiness probes #11107

Conversation

jijiechen commented Aug 13, 2024 • edited Loading

Checklist prior to review

slonka left a comment

Choose a reason for hiding this comment

jijiechen commented Aug 23, 2024 • edited Loading

github-actions bot commented Aug 28, 2024 • edited Loading

lahabana Sep 10, 2024

Choose a reason for hiding this comment

jijiechen commented Aug 13, 2024 •

edited

Loading

jijiechen commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading