Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark "valid-for" as required for command kumactl generate dataplane-token #11848

Closed
jijiechen opened this issue Oct 24, 2024 · 0 comments · Fixed by #11849
Closed

Mark "valid-for" as required for command kumactl generate dataplane-token #11848

jijiechen opened this issue Oct 24, 2024 · 0 comments · Fixed by #11849
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jijiechen
Copy link
Member

What happened?

"valid-for" is currently not marked as required for command kumactl generate dataplane-token
Executing this command without --valid-for will result in an error reported:

Error: failed to generate a dataplane token: You must set a token validFor value

However the message is not clearly telling the user about how can they add this validFor value.
@jijiechen jijiechen added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Oct 24, 2024
@jijiechen jijiechen mentioned this issue Oct 24, 2024
Merged
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Oct 28, 2024
jijiechen added a commit that referenced this issue Oct 29, 2024
@jijiechen
fix(kumactl): mark valid-for as required for command kumactl generate…
68497aa 
… dataplane-token (#11849)

## Motivation

fixes #11848
<!-- Why are we doing this change -->

## Implementation information

Mark the option as required.

Includes a small fixes that resolves
#11107 (comment)

## Supporting documentation

<!-- Is there a MADR? An Issue? A related PR? -->

fixes #11848

<!--
> Changelog: skip
-->
<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

---------

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kumactl): mark valid-for as required for command kumactl generate dataplane-token jijiechen/kuma
2 participants
@jijiechen @jakubdyszkiewicz