Skip to content

Conversation

@antedotee
Copy link
Contributor

@antedotee antedotee commented Nov 14, 2025

Now, the hide controls button will remain collapsed and only expand when someone clicks it. But when someone switches over to other things and then comes back, it will be collapsed by default.

I know, the issue was created keeping in mind the remember the state across navigation, but I intuitively think that if someone is switching over to other thing like grafana chart or lets say main, it will be more convenient to collapse the menu, and when he or she returns to the tree view, he can open it again.

Here is the supporting screenshot:
image

Fixes #2209

@kubestellar-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign btwshivam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
Copy link

Hi @antedotee. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@antedotee antedotee force-pushed the button-auto-pickup-fix branch from 0063cd9 to 01cb035 Compare November 14, 2025 14:58
@antedotee antedotee changed the title fixed the sidebar issue fixed the hide controls issue when it automatically expands by default Nov 15, 2025
@kubestellar-prow kubestellar-prow bot added size/S and removed size/M labels Nov 15, 2025
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
@antedotee antedotee force-pushed the button-auto-pickup-fix branch from 6dae59d to 9a2d3da Compare November 15, 2025 10:24
@antedotee
Copy link
Contributor Author

antedotee commented Nov 15, 2025

@btwshivam @clubanderson Please have a look.

Signed-off-by: antedotee <soniyadav2051982@gmail.com>
@kubestellar-prow kubestellar-prow bot added size/XS and removed size/S labels Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Enhancement: Remember Sidebar State Across Navigation

1 participant