-
Notifications
You must be signed in to change notification settings - Fork 206
fixed the hide controls issue when it automatically expands by default #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @antedotee. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0063cd9 to
01cb035
Compare
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
6dae59d to
9a2d3da
Compare
|
@btwshivam @clubanderson Please have a look. |
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Now, the hide controls button will remain collapsed and only expand when someone clicks it. But when someone switches over to other things and then comes back, it will be collapsed by default.
I know, the issue was created keeping in mind the remember the state across navigation, but I intuitively think that if someone is switching over to other thing like grafana chart or lets say main, it will be more convenient to collapse the menu, and when he or she returns to the tree view, he can open it again.
Here is the supporting screenshot:

Fixes #2209