-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable-admission-plugins flag back in #8399
Conversation
/assign @Bradamant3 |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 6f76543 https://deploy-preview-8399--kubernetes-io-master-staging.netlify.com |
|
||
|
||
## Is there a recommended set of admission controllers to use? | ||
|
||
Yes. | ||
For Kubernetes >= 1.9.0, we strongly recommend running the following set of admission controllers (order matters for 1.9 but not >1.10): | ||
|
||
For Kubernetes version 1.10 and later, we recommend running the following set of admission controllers using the ```--enable-admission-plugins``` flag (**order doesn't matter**). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use single back ticks for the flag, i.e.: `--enable-admission-plugins`
Thanks very much @billpratt Not sure what happened here with the Hugo migration, but I'll check to make sure we don't have any more like this. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#8198 was overwritten with #8316. Adding it back in