-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert site to Hugo #8316
Convert site to Hugo #8316
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit e524d67 https://deploy-preview-8316--kubernetes-io-master-staging.netlify.com |
/approve @bep 👋 Please resolve the merge conflicts. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zacharysarah this PR didn't have any merge conflicts when I opened it. This operation only works if you put a effective freeze on the master branch during the review of this PR. And that includes a revert or whatever of 7745f0e -- which made the conflict in this case. If I have to go back and do a new migration for every commit you make from now on in master, that is 1-2 hours per migration, which does not sound cost effective. |
This commit converts content and layout to use Hugo.
@zacharysarah I have "hand rebased" against master, which was OK for this one small change. But any "bigger changes" needs a roundtrip via a full conversion, so a freeze of some sort would be good. |
@bep 👋
👍
Done. A freeze is in place, announced in #sig-docs Slack. |
Here we go. 🚀 /lgtm |
i think this change is unintended? it should be:
not:
note: i did not test the command without |
This commit converts content and layout to use Hugo.
This includes a complete Netlify configuration (see netlify.toml) for production and branches (incl. PRs), so this should just work.
Note that you should clean up some old config in the Netlify console, but netlify.toml should take precedence.
There are some known tasks that need to be done to make this conversion complete, but that is easier to do once this is merged. Then edits can be applied without having to think about keeping the two content trees in synch.