Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template note for 1.9 #5943

Merged
merged 3 commits into from
Oct 19, 2017
Merged

PR template note for 1.9 #5943

merged 3 commits into from
Oct 19, 2017

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Oct 17, 2017

From the K8s docs release playbook:

Add a reminder in the pull request template for PRs going into the new release to use the release base branch and set the Milestone

The 1.9 milestone is here.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 24fdf97

https://deploy-preview-5943--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor Author

@abiogenesis-now If this looks good to you, go ahead and merge, please. 🙇

@steveperry-53 steveperry-53 merged commit cade8aa into kubernetes:master Oct 19, 2017
@jesscodez
Copy link
Contributor

ah sorry I missed this!

mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
* Document new checks added as part of kubernetes#5943

Related PR linkerd/linkerd2#5943

Related Issue linkerd/linkerd2#5718

Signed-off-by: Szymon Gibała <szymongib@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants